[GitHub] [solr] epugh commented on pull request #1220: SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

2022-12-15 Thread GitBox
epugh commented on PR #1220: URL: https://github.com/apache/solr/pull/1220#issuecomment-1353303993 @dsmiley @risdenk I think I am ready for another review after addressing feedback. Can I get a LGTM? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr] epugh commented on pull request #1220: SOLR-10463: setRetryExpiryTime should be deprecated in favor of Solr Client Builder methods

2022-12-09 Thread GitBox
epugh commented on PR #1220: URL: https://github.com/apache/solr/pull/1220#issuecomment-1344483969 > You added to the Builder but never consumed it! Do this in CloudSolrClient which is the base of the new & old impls. > > You said we do not _use_ this property but I believe you mean w