epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1693381033
Please do! The improvement in the 9x line (as well as main) to the code
quality has been huge, but there is so much more to do.
--
This is an automated message from the Apache Git Servic
epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1689819425
Thanks for these updates! For staight up code refactorings we don't
normally do a CHANGES.txt entry, but I very much appreciate the contribution.
--
This is an automated message from the Ap
epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1689818267
> I am a bit confused, so why would we need an assert at a place where it is
impossible for the Socket to be null?
Because otherwise precommit fails ;-). We really should figure out wh
epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1688716006
Actually, I went ahead and fixed the precommit... going to run the tests
and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
epugh commented on PR #1834:
URL: https://github.com/apache/solr/pull/1834#issuecomment-1688684161
@renatoh can you check the precommit failure? It's a weird one where we
can't do waht the warning tells us to do Please ping me if I don't get
this merged after you get precommit fixed
