epugh commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1741013117
Okay, I'd love some review on this, I think it's more or less ready!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
epugh commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1737508322
Holy smokes, almost everything is building/running cleanly, and that crave
failure of
`org.apache.solr.cli.DeleteToolTest.testFailsToDeleteProtectedCollection` runs
locally just fine.. (?)..
epugh commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1735521281
> re. this pattern of parsing `user:password`
>
> ```
> if (credentials != null && credentials.indexOf(":") > 0) {
> String[] credentialsArray = credentials.split(":");
> `
epugh commented on PR #1954:
URL: https://github.com/apache/solr/pull/1954#issuecomment-1734493799
> re. this pattern of parsing `user:password`
>
> ```
> if (credentials != null && credentials.indexOf(":") > 0) {
> String[] credentialsArray = credentials.split(":");
> `
