[GitHub] [solr] epugh commented on pull request #577: SOLR-15745: Convert remaining 'core-admin' v2 APIs to annotations

2022-01-31 Thread GitBox
epugh commented on pull request #577: URL: https://github.com/apache/solr/pull/577#issuecomment-1025861321 Looks great, I love seeing some of those "shim" like classes like `CoreApiMapping` get removed in favour of what seems more straightforward java code! -- This is an automated messa

[GitHub] [solr] epugh commented on pull request #577: SOLR-15745: Convert remaining 'core-admin' v2 APIs to annotations

2022-01-29 Thread GitBox
epugh commented on pull request #577: URL: https://github.com/apache/solr/pull/577#issuecomment-1024908808 I will look in more detail later, maybe Monday. One thought however if we have v2 internal only apis then does that mean we could remove those v1 equivalents??? -- This is