[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-07-06 Thread GitBox
epugh commented on PR #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1176452054 down tjhe road, we can get rid of the JSON and make it all pure admin gui. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-07-06 Thread GitBox
epugh commented on PR #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1176451785 @janhoy @madrob any last comments? I think this is ready for merging from my perspective ;-).I'd love to merge this tomorrow as @ackepenek has been waiting a while to get this to "done done

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-07-06 Thread GitBox
epugh commented on PR #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1176127063 I like how you nested the drop down inside of it! checking it out todya! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-07-03 Thread GitBox
epugh commented on PR #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1173136119 I like your suggestion @janhoy and that would get this to done. @ackepenek what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-03-22 Thread GitBox
epugh commented on pull request #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1075441419 Thank you for looking @madrob and @janhoy...So the first version that @ackepenek had was basically the "Add field type Template". You just put in the JSON, without the `add-fiel

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-03-21 Thread GitBox
epugh commented on pull request #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1074006014 > If you are ok to manage the add, delete, replace operations with single text area(json field). I can update the PR. Go for it! -- This is an automated message from the Ap

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-03-21 Thread GitBox
epugh commented on pull request #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1073863796 @ackepenek so I tried out the feature locally, and I really like it, but did have a thought Instead of this being a hard coded to the `add-field-type` command, what if instead i

[GitHub] [solr] epugh commented on pull request #753: SOLR-16005 added new feature in to schema screen: add new field type

2022-03-21 Thread GitBox
epugh commented on pull request #753: URL: https://github.com/apache/solr/pull/753#issuecomment-1073834692 Thanks @ackepenek, left a review. How would you like to be credited in the changelog??? -- This is an automated message from the Apache Git Service. To respond to the message, ple