epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1281421975
Okay, this time things ran! Thanks for the fixes @risdenk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1281294752
I was on the wrong branch, and just was testing out `
java.lang.AssertionError: One of the overrides of setUp does not propagate the
call.` these as well...
--
This is an automated message fr
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1279731992
it this PR maybe just going down the wrong approach? I'm not wedded to
this one, it felt a bit werid to me as well.
--
This is an automated message from the Apache Git Service.
To respond to
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1279494678
> I merged main to this. @epugh were you going to do the forbiddenapis
stuff? This looks like it never got merged. The tests should be kicked off
again shortly.
I tried the forbiddenapis,
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1232831100
I've fixed the merge conflict, so I'd like to merge this PR this week, so
then I can move on to the new plan of fixing the unit test warnings package by
package instead of type by type.
--
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1227689974
Thanks for approving the changes @uschindler! I'm waiting on @cpoerschke to
finish her review, and the SolrJ-Zookeeper to get merged, and then I'll merge
this one!
--
This is an automated me
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1227220289
I gave it a stab of adding it to forbiddenapis, but didn't quite get it to
work... There are *some* places that it's okay, like in the LTR module...
May need a pairing session to grok this!
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1225833107
> 19 / 26 files viewed
>
> I wonder if we could/should also put the assert versions in question on
the 'forbidden list' e.g.
https://github.com/apache/solr/tree/main/gradle/validation/for
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1195594149
@cpoerschke I'd love a review, I think this is ready!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1195548367
So, I am rethinking this PR... I think I was falling into the trap of
having too many different changes in one PR... So, I'm going to remove the
task "Double check all the files for other ass
epugh commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1190727394
Did a bit more work, and I think we should:
- [ ] Eliminate all the `MatcherAssert.assertThat` and just have
`assertThat()`
- [ ] Eliminate all the `@Rule public ExpectedException` in f
11 matches
Mail list logo
