[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r966121020 ## solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java: ## @@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) { } @GET - @Produces("ap

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r966044159 ## solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java: ## @@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) { } @GET - @Produces("ap

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r966024055 ## solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java: ## @@ -40,4 +44,41 @@ public static void flattenToCommaDelimitedString( final String flattenedStr

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r966015071 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -273,7 +278,7 @@ public static Api getApiInfo( } if (api == null) { - return getSubPathA

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r966010573 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -388,33 +335,65 @@ public CompositeApi add(Api api) { } } + // We don't rely on any of Jersey'

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965970532 ## solr/core/src/java/org/apache/solr/jersey/SolrJerseyResponse.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965949607 ## solr/core/src/test/org/apache/solr/handler/configsets/ListConfigSetsAPITest.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-08 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965936792 ## solr/core/src/java/org/apache/solr/jersey/CatchAllExceptionMapper.java: ## @@ -93,10 +98,12 @@ public Response toResponse(Exception exception) { RequestHandlerB

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-07 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965335669 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -16,12 +16,51 @@ */ package org.apache.solr.core; +import static java.util.Objects.requireNonNul

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-07 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r965213364 ## solr/core/src/test/org/apache/solr/handler/configsets/ListConfigSetsAPITest.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-07 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r964814595 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -362,14 +363,15 @@ private void invokeJerseyRequest(CoreContainer cores, SolrCore core, Application

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-09-01 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r960599028 ## solr/core/src/java/org/apache/solr/jersey/PostRequestDecorationFilter.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959835650 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -397,7 +399,7 @@ protected void handleAdmin(SolrQueryResponse solrResp) { @Override protected void

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959815458 ## solr/core/src/java/org/apache/solr/jersey/PostRequestDecorationFilter.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959811323 ## solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java: ## @@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) { } @GET - @Produces("ap

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-31 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r959808595 ## solr/core/src/java/org/apache/solr/core/PluginBag.java: ## @@ -27,8 +27,7 @@ import org.apache.solr.common.util.StrUtils; import org.apache.solr.handler.RequestHandl

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-30 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r958598470 ## solr/core/src/java/org/apache/solr/api/V2HttpCall.java: ## @@ -362,14 +363,15 @@ private void invokeJerseyRequest(CoreContainer cores, SolrCore core, Application

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-30 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r958476775 ## solr/core/src/java/org/apache/solr/handler/admin/api/SchemaNameAPI.java: ## @@ -46,7 +46,7 @@ public SchemaNameAPI(SolrCore solrCore) { } @GET - @Produces("ap

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-25 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r954969780 ## solr/core/src/java/org/apache/solr/handler/configsets/ListConfigsetsResponse.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-24 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r953842424 ## solr/core/src/java/org/apache/solr/handler/configsets/ListConfigsetsResponse.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-24 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r953832066 ## solr/core/src/java/org/apache/solr/handler/configsets/ListConfigSetsAPI.java: ## @@ -16,34 +16,54 @@ */ package org.apache.solr.handler.configsets; -import static

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-24 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r953822401 ## solr/core/src/java/org/apache/solr/handler/admin/ConfigSetsHandler.java: ## @@ -75,6 +77,18 @@ public static boolean isAutoGeneratedConfigSet(String configName) {

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-24 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r953816961 ## solr/core/src/java/org/apache/solr/handler/api/SomeCoreResource.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-19 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r950237076 ## solr/core/src/java/org/apache/solr/handler/api/SomeCoreResource.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [solr] gerlowskija commented on a diff in pull request #975: Allow JAX-RS v2 API definition

2022-08-19 Thread GitBox
gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r948326320 ## solr/core/src/java/org/apache/solr/handler/api/SomeCoreHandler.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *