gerlowskija commented on PR #1859: URL: https://github.com/apache/solr/pull/1859#issuecomment-1690318842
Yeah, the diff is large for sure. I'd argue though that this is pretty deceptive though, re: "verbosity". This commit adds lines in isolation sure, but if it ultimately lets us delete a bunch of existing SolrJ (and maybe even ref-guide) code that we've been maintaining by hand up to this point...well then the end result will be a huge "net-negative" in terms of LOC. (In theory we could nuke the v1 SolrRequest classes in this PR, if we wanted to commit to removing them in 10.0. I was reluctant to do that here though, since there's a lot of v2 api work remaining and the 10.0 timeline being a real unknown...) Anyway in the short term I def agree it's non-ideal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
