[GitHub] [solr] gerlowskija commented on pull request #577: SOLR-15745: Convert remaining 'core-admin' v2 APIs to annotations

2022-01-29 Thread GitBox
gerlowskija commented on pull request #577: URL: https://github.com/apache/solr/pull/577#issuecomment-1025059588 Ok, no rush. And thanks, I appreciate the review - I know they take time! > does that mean we could remove those v1 equivalents??? We probably could. Though tbh I'm

[GitHub] [solr] gerlowskija commented on pull request #577: SOLR-15745: Convert remaining 'core-admin' v2 APIs to annotations

2022-01-28 Thread GitBox
gerlowskija commented on pull request #577: URL: https://github.com/apache/solr/pull/577#issuecomment-1024797869 One note about this PR: unlike a lot of the other API-conversions I've done recently, this one **isn't** a straight refactor/reimplementation. The `CoreApiMapping` Java fi