[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1304351888 ## solr/core/src/java/org/apache/solr/core/NodeConfig.java: ## @@ -567,6 +575,7 @@ public static class NodeConfigBuilder { private String defaultZkHost; private

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303615766 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -135,4 +182,8 @@ public static ErrorInfo getTypedErrorInfo(Throwable ex, Logger log) { error

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303615333 ## solr/core/src/java/org/apache/solr/core/NodeConfig.java: ## @@ -567,6 +575,7 @@ public static class NodeConfigBuilder { private String defaultZkHost; private

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303615200 ## solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303614343 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -28,6 +28,11 @@ public class ResponseUtils { private ResponseUtils() {} + // System propert

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303381080 ## solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303382150 ## solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1303381080 ## solr/core/src/test/org/apache/solr/servlet/HideStackTraceTest.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1298864143 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -96,6 +120,22 @@ public static int getErrorInfo(Throwable ex, NamedList info, Logger log) * @

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1298863878 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -135,4 +177,10 @@ public static ErrorInfo getTypedErrorInfo(Throwable ex, Logger log) { erro

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1298862178 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -42,6 +43,26 @@ private ResponseUtils() {} * @see #getTypedErrorInfo(Throwable, Logger) */

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1297843290 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -135,4 +177,10 @@ public static ErrorInfo getTypedErrorInfo(Throwable ex, Logger log) { erro

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1192621167 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -971,7 +971,7 @@ protected void writeResponse( if (solrRsp.getException() != null) {

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1192534779 ## solr/core/src/java/org/apache/solr/rest/BaseSolrResource.java: ## @@ -143,7 +143,11 @@ protected void handleException(Logger log) { Exception exception = getSolrR

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1192381371 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -70,10 +90,13 @@ public static int getErrorInfo(Throwable ex, NamedList info, Logger log)

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1190310363 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -971,7 +975,11 @@ protected void writeResponse( if (solrRsp.getException() != null) {

[GitHub] [solr] igiguere commented on a diff in pull request #1632: SOLR-14886 : suppress stack traces in query response

igiguere commented on code in PR #1632: URL: https://github.com/apache/solr/pull/1632#discussion_r1190308248 ## solr/core/src/java/org/apache/solr/servlet/ResponseUtils.java: ## @@ -70,10 +90,13 @@ public static int getErrorInfo(Throwable ex, NamedList info, Logger log)