[GitHub] [solr] janhoy commented on a change in pull request #558: SOLR-9575 Allow starting with an empty SOLR_HOME

2022-01-29 Thread GitBox
janhoy commented on a change in pull request #558: URL: https://github.com/apache/solr/pull/558#discussion_r795065866 ## File path: solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java ## @@ -168,34 +178,29 @@ public void stop() { // zoo.cfg (which validates that there i

[GitHub] [solr] janhoy commented on a change in pull request #558: SOLR-9575 Allow starting with an empty SOLR_HOME

2022-01-28 Thread GitBox
janhoy commented on a change in pull request #558: URL: https://github.com/apache/solr/pull/558#discussion_r794307508 ## File path: solr/solr-ref-guide/src/configuring-solr-xml.adoc ## @@ -543,7 +553,6 @@ If only `dividend` routing is desired, `hash` may be explicitly set to t

[GitHub] [solr] janhoy commented on a change in pull request #558: SOLR-9575 Allow starting with an empty SOLR_HOME

2022-01-28 Thread GitBox
janhoy commented on a change in pull request #558: URL: https://github.com/apache/solr/pull/558#discussion_r794302250 ## File path: solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java ## @@ -161,14 +162,21 @@ public static NodeConfig fromConfig(Path solrHome, XmlConfigF

[GitHub] [solr] janhoy commented on a change in pull request #558: SOLR-9575 Allow starting with an empty SOLR_HOME

2022-01-28 Thread GitBox
janhoy commented on a change in pull request #558: URL: https://github.com/apache/solr/pull/558#discussion_r794299684 ## File path: solr/bin/solr ## @@ -2069,8 +2069,11 @@ if [ "$SOLR_MODE" == 'solrcloud' ]; then CLOUD_MODE_OPTS+=('-Dbootstrap_confdir=./solr/collection1/co