[GitHub] [solr] janhoy commented on a diff in pull request #1552: SOLR-16714: addDepsToChanges.py handle empty gitlog

2023-04-10 Thread via GitHub
janhoy commented on code in PR #1552: URL: https://github.com/apache/solr/pull/1552#discussion_r1161831927 ## dev-tools/scripts/addDepsToChanges.py: ## @@ -102,6 +104,11 @@ def update_changes(filename, version, changes_lines): buffer.append(change_line)

[GitHub] [solr] janhoy commented on a diff in pull request #1552: SOLR-16714: addDepsToChanges.py handle empty gitlog

2023-04-10 Thread via GitHub
janhoy commented on code in PR #1552: URL: https://github.com/apache/solr/pull/1552#discussion_r1161815684 ## dev-tools/scripts/addDepsToChanges.py: ## @@ -124,8 +125,11 @@ def main(): gitlog_lines = run( 'git log --author=' + newconf.user + ' --oneline --n

[GitHub] [solr] janhoy commented on a diff in pull request #1552: SOLR-16714: addDepsToChanges.py handle empty gitlog

2023-04-10 Thread via GitHub
janhoy commented on code in PR #1552: URL: https://github.com/apache/solr/pull/1552#discussion_r1161815414 ## dev-tools/scripts/addDepsToChanges.py: ## @@ -124,8 +125,11 @@ def main(): gitlog_lines = run( 'git log --author=' + newconf.user + ' --oneline --n