janhoy commented on code in PR #1725:
URL: https://github.com/apache/solr/pull/1725#discussion_r1308693783
##
solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
janhoy commented on code in PR #1725:
URL: https://github.com/apache/solr/pull/1725#discussion_r1308640769
##
solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java:
##
@@ -0,0 +1,314 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
janhoy commented on code in PR #1725:
URL: https://github.com/apache/solr/pull/1725#discussion_r1304410860
##
solr/core/src/test-files/solr/collection1/conf/solrconfig-legacy-circuitbreaker.xml:
##
@@ -78,11 +78,14 @@
-
+
+
true
-75
+80
true
-
janhoy commented on code in PR #1725:
URL: https://github.com/apache/solr/pull/1725#discussion_r1304292604
##
solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc:
##
@@ -27,23 +27,16 @@ If circuit breakers are enabled, requests may be rejected
under the con
janhoy commented on code in PR #1725:
URL: https://github.com/apache/solr/pull/1725#discussion_r1304289358
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
janhoy commented on code in PR #1725:
URL: https://github.com/apache/solr/pull/1725#discussion_r1304282600
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java:
##
@@ -36,26 +36,24 @@ public class MemoryCircuitBreaker extends CircuitBreaker {
pr
janhoy commented on code in PR #1725:
URL: https://github.com/apache/solr/pull/1725#discussion_r1303062115
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -38,31 +38,24 @@ public class CPUCircuitBreaker extends CircuitBreaker {
private
