[GitHub] [solr] janhoy commented on a diff in pull request #1841: SOLR-16354 Migrate from Jaeger/OpenTracing to OTEL

2023-08-15 Thread via GitHub
janhoy commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294526185 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -977,15 +979,32 @@ protected void writeResponse( } if (Method.HEAD != reqMethod) { -

[GitHub] [solr] janhoy commented on a diff in pull request #1841: SOLR-16354 Migrate from Jaeger/OpenTracing to OTEL

2023-08-15 Thread via GitHub
janhoy commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294524997 ## solr/core/src/java/org/apache/solr/core/TracerConfigurator.java: ## @@ -17,83 +17,88 @@ package org.apache.solr.core; -import io.opentracing.Scope; -import io.opent

[GitHub] [solr] janhoy commented on a diff in pull request #1841: SOLR-16354 Migrate from Jaeger/OpenTracing to OTEL

2023-08-15 Thread via GitHub
janhoy commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294442984 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -16,38 +16,56 @@ */ package org.apache.solr.opentelemetry; -imp