[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-06 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1316882036 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreaker.java: ## @@ -52,4 +62,48 @@ public CircuitBreaker() {} /** Get error message when the circuit

[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-05 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1315609098 ## solr/core/src/test-files/solr/collection1/conf/solrconfig-pluggable-circuitbreaker.xml: ## @@ -80,6 +80,18 @@ 75 + + update + + + + +80 +

[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-05 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1315605803 ## solr/core/src/java/org/apache/solr/handler/ContentStreamHandlerBase.java: ## @@ -101,6 +112,30 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse

[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-05 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1315493607 ## solr/core/src/java/org/apache/solr/handler/ContentStreamHandlerBase.java: ## @@ -101,6 +112,30 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse

[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-04 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1315169354 ## solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc: ## @@ -72,6 +73,30 @@ To enable and configure the CPU utilization based circuit breaker: Th

[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-04 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1315168456 ## solr/core/src/java/org/apache/solr/handler/ContentStreamHandlerBase.java: ## @@ -101,6 +112,30 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse

[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-09-04 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1315162891 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/RequestType.java: ## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [solr] janhoy commented on a diff in pull request #1871: SOLR-16954 Make Circuit Breakers available for Update Requests

2023-08-29 Thread via GitHub
janhoy commented on code in PR #1871: URL: https://github.com/apache/solr/pull/1871#discussion_r1309302038 ## solr/core/src/java/org/apache/solr/handler/ContentStreamHandlerBase.java: ## @@ -63,6 +70,17 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rs