[GitHub] [solr] janhoy commented on a diff in pull request #1919: SOLR-16974: Global Circuit Breakers

2023-09-26 Thread via GitHub
janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1337018213 ## solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java: ## @@ -814,6 +815,7 @@ public Path getInstancePath() { new Class[] { // DO NOT ADD T

[GitHub] [solr] janhoy commented on a diff in pull request #1919: SOLR-16974: Global Circuit Breakers

2023-09-23 Thread via GitHub
janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1335063163 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -33,39 +35,47 @@ * We depend on OperatingSystemMXBean which does not allow a confi

[GitHub] [solr] janhoy commented on a diff in pull request #1919: SOLR-16974: Global Circuit Breakers

2023-09-23 Thread via GitHub
janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1334976074 ## solr/core/src/test/org/apache/solr/util/TestGlobalCircuitBreaker.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] janhoy commented on a diff in pull request #1919: SOLR-16974: Global Circuit Breakers

2023-09-13 Thread via GitHub
janhoy commented on code in PR #1919: URL: https://github.com/apache/solr/pull/1919#discussion_r1324459082 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerRegistry.java: ## @@ -62,9 +81,11 @@ public void deregisterAll() { */ public List checkTrippe