[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1331630936 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codahale.

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1330787224 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codahale.

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1327846742 ## solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc: ## @@ -24,12 +24,19 @@ resource configuration. Circuit breakers should be used when the user wishe

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1327778603 ## solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc: ## @@ -24,12 +24,19 @@ resource configuration. Circuit breakers should be used when the user wishe

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1315215619 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codahale.

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1315215619 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codahale.

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1311946171 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codahale.

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1310587960 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.codahale.

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1310168797 ## solr/core/src/test/org/apache/solr/util/BaseTestCircuitBreaker.java: ## @@ -193,6 +195,55 @@ public void testFakeCPUCircuitBreaker() { } } + public void testFakeL

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1310122961 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/LoadAverageCircuitBreaker.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1310120363 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java: ## @@ -40,12 +41,15 @@ * solution. There will be a follow up with a SIP for a schema API

[GitHub] [solr] janhoy commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

janhoy commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1310118157 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -110,6 +113,27 @@ public double getCpuUsageThreshold() { } protected double calc