janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1696924284
Looking for at least one "+1" before I proceed with the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1693434188
> When you said "Then this is a nice foundation to build /update circuit
breaking on top of.", I this caught my interest as this is what we're doing
with Solr where I work. If this PR doesn't
janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1692976849
> My colleagues have done some custom Circuit Breaking stuff in Solr... I'm
hoping one of them might weigh-in here so please don't merge too quickly.
This is not really touching the exi
janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1691786000
@dsmiley, @elyograg: I think this is ready, but appreciate if one of you
would skim over this PR and see what you find.
--
This is an automated message from the Apache Git Service.
To respo
janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1691677121
Will likely need to squash and force-push in order for Crave.io to do its
job... Anyone have a problem with that?
--
This is an automated message from the Apache Git Service.
To respond to
janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1691647753
Thanks for reviewing @cpoerschke. Last bit of polish and then I hope to wrap
up. Then this is a nice foundation to build `/update` circuit breaking on top
of. I plan to let each CB plugin dec
janhoy commented on PR #1725:
URL: https://github.com/apache/solr/pull/1725#issuecomment-1690068424
In the last commits I re-introduced backward compatibility for configuring
the legacy "CircuitBreakerManager" as a single plugin. I did this by renaming
`CircuitBreakerManager` as `CircuitBre
