[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r922256956 ## solr/solrj/src/java/org/apache/solr/common/util/CommonTestInjection.java: ## @@ -39,4 +45,31 @@ public static void setAdditionalProps(Map additionalSystemProps) public

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915426740 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +245,125 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashMap

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915422193 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -549,7 +636,7 @@ private void constructState(Set changedCollections) { log.trace(

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915422007 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -540,7 +627,7 @@ private void constructState(Set changedCollections) { log.debug(

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915420568 ## solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java: ## @@ -29,35 +38,68 @@ import org.apache.solr.cloud.ZkTestServer; import org.apache.solr.common.

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915147046 ## solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -246,6 +244,90 @@ public boolean canBeRemoved() { } } + /** + * A ConcurrentHashMap

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r915138036 ## solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java: ## @@ -184,16 +195,210 @@ public void testWatchedCollectionCreation() throws Exception { w

[GitHub] [solr] madrob commented on a diff in pull request #909: SOLR-16257: `ZkStateReader` changes to avoid race condition between `collectionWatches` and `watchedCollectionStates`

madrob commented on code in PR #909: URL: https://github.com/apache/solr/pull/909#discussion_r910461025 ## solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java: ## @@ -196,4 +209,251 @@ public void testWatchedCollectionCreation() throws Exception { se