[GitHub] [solr] noblepaul commented on a change in pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-11-02 Thread GitBox
noblepaul commented on a change in pull request #160: URL: https://github.com/apache/solr/pull/160#discussion_r741505697 ## File path: solr/core/src/test/org/apache/solr/core/TestConfLoadPerf.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [solr] noblepaul commented on a change in pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-10-28 Thread GitBox
noblepaul commented on a change in pull request #160: URL: https://github.com/apache/solr/pull/160#discussion_r738934725 ## File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java ## @@ -564,7 +641,7 @@ public HttpCachingConfig getHttpCachingConfig() { "ca

[GitHub] [solr] noblepaul commented on a change in pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-10-28 Thread GitBox
noblepaul commented on a change in pull request #160: URL: https://github.com/apache/solr/pull/160#discussion_r738931310 ## File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java ## @@ -158,6 +166,27 @@ public static SolrConfig readFromResourceLoader(SolrResourceLo

[GitHub] [solr] noblepaul commented on a change in pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-10-28 Thread GitBox
noblepaul commented on a change in pull request #160: URL: https://github.com/apache/solr/pull/160#discussion_r738931062 ## File path: solr/core/src/resources/EditableSolrConfigAttributes.json ## @@ -56,10 +56,6 @@ "enableLazyFieldLoading":1, "boolTofilterOptimizer":1

[GitHub] [solr] noblepaul commented on a change in pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-10-28 Thread GitBox
noblepaul commented on a change in pull request #160: URL: https://github.com/apache/solr/pull/160#discussion_r738927739 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -730,12 +730,11 @@ protected void postReadInform() { * Loads the copy fiel