renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1721339817
@epugh Hey Eric, could you please give me a hand with this PR? I do not
understand what the issue is.
Thanks
--
This is an automated message from the Apache Git Service.
To respond
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1710188125
@epugh is it possible that you have a look at tell me what's wrong with my
commit? I don't what the issue is
--
This is an automated message from the Apache Git Service.
To respond to the
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1707871257
@cpoerschke I did another merge of origin/main, it looks like the checks
have now passed, or haven't they?
--
This is an automated message from the Apache Git Service.
To respond to the me
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1705604995
@cpoerschke do you know why patches are applied e.g. "Applying: SOLR-16871:
Synchronize on a larger block to avoid race condition in
CoordinatorHttpSolrCall init" as a part of the build?
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1705440090
@cpoerschke I did that, and it shows me that my fork is up to date, but I am
getting:
(#error: patch failed:
solr/core/src/java/org/apache/solr/cli/AssertTool.java:35
--
This is an aut
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1702234144
hmm, now JavaSpotless check is failing on a class I have not touched, this
one:
src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java
--
This is an auto
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1700433722
i don't see whats why the Precommit is complaining about
SpellCheckComponent.java, I did run tidy again, and no changes appear.
--
This is an automated message from the Apache Git Service.
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1699695874
@madrob I might have been wrong with the static code analysis, looks like it
is even a compiler warning:
