[GitHub] [solr] risdenk commented on a diff in pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

2023-04-01 Thread via GitHub
risdenk commented on code in PR #1501: URL: https://github.com/apache/solr/pull/1501#discussion_r1155113686 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/MinimizeCoresPlacementFactory.java: ## @@ -123,20 +123,23 @@ public List computePlacements( // r

[GitHub] [solr] risdenk commented on a diff in pull request #1501: SOLR-16713: Replace Guava usages with pure Java (part 2)

2023-04-01 Thread via GitHub
risdenk commented on code in PR #1501: URL: https://github.com/apache/solr/pull/1501#discussion_r1155113182 ## solr/solrj/src/java/org/apache/solr/common/util/StrUtils.java: ## @@ -363,4 +366,16 @@ public static String formatString(String pattern, Object... args) { public st