[GitHub] [solr] risdenk commented on pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions

2022-09-08 Thread GitBox
risdenk commented on PR #1001: URL: https://github.com/apache/solr/pull/1001#issuecomment-1240923591 So in commit 02cecd6731874465537e5b688cfcf1d0e60f5503, I finally found a log2m value that gives some accurate enough results for testing. I am beasting this test to make sure all is good.

[GitHub] [solr] risdenk commented on pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions

2022-09-07 Thread GitBox
risdenk commented on PR #1001: URL: https://github.com/apache/solr/pull/1001#issuecomment-1239892447 > I think the above error is actually https://issues.apache.org/jira/browse/SOLR-10918 ehhh it might be related - but running `./gradlew -p solr/core beast -Ptests.dups=10 --tests "

[GitHub] [solr] risdenk commented on pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions

2022-09-07 Thread GitBox
risdenk commented on PR #1001: URL: https://github.com/apache/solr/pull/1001#issuecomment-1239884621 I think the above error is actually https://issues.apache.org/jira/browse/SOLR-10918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [solr] risdenk commented on pull request #1001: SOLR-16405: Remove unneeded errorprone suppressions

2022-09-07 Thread GitBox
risdenk commented on PR #1001: URL: https://github.com/apache/solr/pull/1001#issuecomment-1239792082 I think this found a potentially real bug in: ``` TestDistributedStatsComponentCardinality > java.lang.AssertionError: int_i: relativeErr=0.09722718241315029, estimate