[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-12 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1276422283 > If current solution works, then go for it. > > The only thing I worry is that some other part of Solr requesting someting like `$SOLR_TIP/foo` would now start failing but could be th

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275291936 test failure is expected - is resolved by https://github.com/apache/solr/pull/1044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275291318 @dsmiley @janhoy @HoustonPutman - can you please double check my `solr/docker/templates/Dockerfile.body.template` changes? it looks good to me and shouldn't be an issue w/ backwards compat.

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275281158 `SOLR_SERVER_DIR="/opt/solr-${SOLR_VERSION}/server" \` added to handle Jetty home looking at canonical path -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275220386 Error running locally `./gradlew -p solr/docker testDocker`: ``` java.security.AccessControlException: access denied ("java.io.FilePermission" "/opt/solr-10.0.0-SNAPSHOT/server/star

[GitHub] [solr] risdenk commented on pull request #1066: SOLR-16457: solr.data.home should not be set to empty string

2022-10-11 Thread GitBox
risdenk commented on PR #1066: URL: https://github.com/apache/solr/pull/1066#issuecomment-1275087180 I'm planning to merge this with https://github.com/apache/solr/pull/1044 since without the changes from https://github.com/apache/solr/pull/1044 - this PR will fail by itself. -- This is