risdenk commented on PR #1945:
URL: https://github.com/apache/solr/pull/1945#issuecomment-1737383196
@psalagnac @patsonluk I pushed
[7532168](https://github.com/apache/solr/pull/1945/commits/7532168b7813cf0c64ef1c935c0a1d9b0527e25f)
which checks the predicate in waitForState
--
This is a
risdenk commented on PR #1945:
URL: https://github.com/apache/solr/pull/1945#issuecomment-1736282859
Agreed thought about that as I was looking at this more. Will update
tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
risdenk commented on PR #1945:
URL: https://github.com/apache/solr/pull/1945#issuecomment-1731701371
I fixed a similar race condition in
[269d19b](https://github.com/apache/solr/pull/1945/commits/269d19b3a95b8de35130020facc8c47fab391c77)
that makes sure there is a new leader before we try t
risdenk commented on PR #1945:
URL: https://github.com/apache/solr/pull/1945#issuecomment-1731554823
I ran into this reproducing failure - `gradlew test --tests
LeaderElectionIntegrationTest.testSimpleSliceLeaderElection
-Dtests.seed=7FE90E71BD77ABA3 -Dtests.locale=ga-Latn-IE
-Dtests.timez
risdenk commented on PR #1945:
URL: https://github.com/apache/solr/pull/1945#issuecomment-1729864492
I'd appreciate some thoughts on this. This doesn't fix the `setupRequest`
being called twice, but should make the `setupRequest` method much faster by
not having to lock and check for leader
