risdenk commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1024422694
I went through these two and I'm not sure there is a good way to address
them right now. I don't think it should hold up the merge of this PR.
* render-javadoc needs a little
risdenk commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1023680842
So current status as I see it:
* render-javadoc needs a little more attention - basically shouldn't need so
many changes
* `Abstract*Base` test files moved to test-framework -
risdenk commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1018680697
> I'm concerned about this missing changes to the Hadoop code from the
endianness fix, the upgrade to 3.3.1, and whatever else we've had to patch up
since this PR was originally ope
risdenk commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1017779969
BTW I went through all the files and there aren't THAT many files that need
to be reviewed for real changes.
* ~344/447 are just test-files - a lot could be removed?
* ~57/447
risdenk commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1017774402
@warperwolf do you have recent changes/updates on this? I can take a stab at
updating and fixing some of the comments.
--
This is an automated message from the Apache Git Service.
