[GitHub] [solr] senthh commented on pull request #1669: SOLR-16826: Validate if authentication plugin class name are valid

2023-05-30 Thread via GitHub
senthh commented on PR #1669: URL: https://github.com/apache/solr/pull/1669#issuecomment-1569532965 > Oh okay, then both org.apache.solr.security.hadoop.*Plugin and solr.*Plugin works? If it is so I can change in doc > > > Oh okay, then both org.apache.solr.security.hadoop.*Plugin and

[GitHub] [solr] senthh commented on pull request #1669: SOLR-16826: Validate if authentication plugin class name are valid

2023-05-30 Thread via GitHub
senthh commented on PR #1669: URL: https://github.com/apache/solr/pull/1669#issuecomment-1568856607 > The `org.apache.solr.security.*Plugin` still works, but the issue is that the package name changed for the KerberosPlugin from `org.apache.solr.security` (8.x) to `org.apache.solr.security.

[GitHub] [solr] senthh commented on pull request #1669: SOLR-16826: Validate if authentication plugin class name are valid

2023-05-30 Thread via GitHub
senthh commented on PR #1669: URL: https://github.com/apache/solr/pull/1669#issuecomment-1568634452 > I'm not a fan of this solution. Yet a place of strings to maintain. > > What is wrong with the ClassNotFound exception you (probably) already get? Does it not tell you clearly the pro

[GitHub] [solr] senthh commented on pull request #1669: SOLR-16826: Validate if authentication plugin class name are valid

2023-05-28 Thread via GitHub
senthh commented on PR #1669: URL: https://github.com/apache/solr/pull/1669#issuecomment-1565958896 @epugh Eric Pugh, could you please review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go