[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-23 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1303771997 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-23 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1303750750 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-23 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1303744008 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-22 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1301578462 ## solr/core/src/java/org/apache/solr/util/stats/InstrumentedHttpRequestExecutor.java: ## @@ -147,6 +152,13 @@ public HttpResponse execute(HttpRequest request, HttpClie

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-22 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1301571072 ## solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java: ## @@ -114,6 +115,26 @@ public void test() throws IOException, SolrServer

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-22 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1301569725 ## solr/core/src/java/org/apache/solr/util/stats/InstrumentedHttpRequestExecutor.java: ## @@ -147,6 +152,13 @@ public HttpResponse execute(HttpRequest request, HttpClie

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-20 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299447450 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Sof

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-20 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299447062 ## solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299273700 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/simplepropagator/SimplePropagator.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299273658 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Sof

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299273617 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Sof

[GitHub] [solr] stillalex commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
stillalex commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299273498 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Sof