[GitHub] [solr] stillalex commented on a diff in pull request #1958: [WIP] SOLR-16985 Upgrade Lucene to 9.8.0

2023-09-29 Thread via GitHub
stillalex commented on code in PR #1958: URL: https://github.com/apache/solr/pull/1958#discussion_r1341572855 ## solr/core/src/java/org/apache/solr/search/DelegatingCollector.java: ## @@ -80,9 +80,20 @@ protected void doSetNextReader(LeafReaderContext context) throws IOExceptio

[GitHub] [solr] stillalex commented on a diff in pull request #1958: [WIP] SOLR-16985 Upgrade Lucene to 9.8.0

2023-09-28 Thread via GitHub
stillalex commented on code in PR #1958: URL: https://github.com/apache/solr/pull/1958#discussion_r1340547130 ## solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java: ## @@ -145,4 +151,34 @@ public Codec getCodec() { assert core != null : "inform must be called f