[GitHub] [solr] stillalex commented on a diff in pull request #1959: SOLR-16997: OTEL configurator NPE when SOLR_HOST not set

2023-09-26 Thread via GitHub
stillalex commented on code in PR #1959: URL: https://github.com/apache/solr/pull/1959#discussion_r1337164802 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -65,7 +65,9 @@ void prepareConfiguration(NamedList args) { s

[GitHub] [solr] stillalex commented on a diff in pull request #1959: SOLR-16997: OTEL configurator NPE when SOLR_HOST not set

2023-09-26 Thread via GitHub
stillalex commented on code in PR #1959: URL: https://github.com/apache/solr/pull/1959#discussion_r1337153085 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -65,7 +65,9 @@ void prepareConfiguration(NamedList args) { s

[GitHub] [solr] stillalex commented on a diff in pull request #1959: SOLR-16997: OTEL configurator NPE when SOLR_HOST not set

2023-09-26 Thread via GitHub
stillalex commented on code in PR #1959: URL: https://github.com/apache/solr/pull/1959#discussion_r1337153085 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -65,7 +65,9 @@ void prepareConfiguration(NamedList args) { s