stillalex commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1368118096
looks good to me, will leave @dsmiley to add any concerns if any.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
stillalex commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1366757868
I agree eliminating the property is more work. I don't have a preference
here. I would add the system property support (left a comment at the relevant
line) and not remove builder support
stillalex commented on PR #1248:
URL: https://github.com/apache/solr/pull/1248#issuecomment-1364712912
left a few minor comments, overall this looks good.
is updating the `objectList` method on the table? I find this code a bit
ugly (bigger change would be to use an array everywhere,
