[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r639106918 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +201,137 @@ public float getMaxScore(int upTo) throws I

[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r639065556 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +201,137 @@ public float getMaxScore(int upTo) throws I

[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r637047507 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java ## @@ -41,25 +37,33 @@ import org.apache.lucene.search.ScoreMode; i

[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r636367520 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTRReRankingPipeline.java ## @@ -41,25 +37,33 @@ import org.apache.lucene.search.ScoreMode; i

[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r636336976 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -23,24 +23,34 @@ import java.util.Set; import org.apache.l

[GitHub] [solr] tomglk commented on a change in pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r636315533 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -106,18 +106,29 @@ public FieldValueFeatureWeight(IndexSearche

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633827319 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -106,18 +106,29 @@ public FieldValueFeatureWeight(IndexSearche

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633774698 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +171,100 @@ public float getMaxScore(int upTo) throws I

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633062781 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -57,50 +67,79 @@ public void setField(String field) { }

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633270956 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -106,18 +106,29 @@ public FieldValueFeatureWeight(IndexSearche

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633269843 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/feature/TestFieldValueFeature.java ## @@ -56,11 +62,13 @@ public void before() throws Exception {

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633071371 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/feature/TestFieldValueFeature.java ## @@ -70,86 +78,92 @@ public void after() throws Exception {

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633071371 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/feature/TestFieldValueFeature.java ## @@ -70,86 +78,92 @@ public void after() throws Exception {

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r633062781 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -57,50 +67,79 @@ public void setField(String field) { }

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r632068196 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +171,100 @@ public float getMaxScore(int upTo) throws I

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r632064832 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +171,100 @@ public float getMaxScore(int upTo) throws I

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r631694495 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +171,100 @@ public float getMaxScore(int upTo) throws I

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r631642889 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java ## @@ -232,32 +230,47 @@ private void createCollection(String name, String c

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r631641743 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java ## @@ -232,32 +230,47 @@ private void createCollection(String name, String c

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r631640008 ## File path: solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java ## @@ -107,21 +105,21 @@ public void testSimpleQuery() throws Exception {

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r631639505 ## File path: solr/contrib/ltr/src/test-files/solr/collection1/conf/schema.xml ## @@ -18,13 +18,22 @@ - + + + Review comment: Ch

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r631638793 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +171,100 @@ public float getMaxScore(int upTo) throws I

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r631638003 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +171,100 @@ public float getMaxScore(int upTo) throws I

[GitHub] [solr] tomglk commented on a change in pull request #123: [SOLR-12697] Add pure DocValues support to FieldValueFeature

tomglk commented on a change in pull request #123: URL: https://github.com/apache/solr/pull/123#discussion_r631601388 ## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/FieldValueFeature.java ## @@ -146,5 +171,100 @@ public float getMaxScore(int upTo) throws I