[GitHub] [solr] wrunderwood commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2023-09-19 Thread via GitHub
wrunderwood commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1330607590 ## solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java: ## @@ -17,54 +17,49 @@ package org.apache.solr.util.circuitbreaker; +import com.coda

[GitHub] [solr] wrunderwood commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2023-09-19 Thread via GitHub
wrunderwood commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1330486585 ## solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc: ## @@ -48,19 +63,25 @@ To enable and configure the JVM heap usage based circuit breaker, add

[GitHub] [solr] wrunderwood commented on a diff in pull request #96: SOLR-15056: add circuit breaker for CPU, fix load circuit breaker

2023-09-15 Thread via GitHub
wrunderwood commented on code in PR #96: URL: https://github.com/apache/solr/pull/96#discussion_r1327836121 ## solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc: ## @@ -24,12 +24,19 @@ resource configuration. Circuit breakers should be used when the user