gerlowskija commented on pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#issuecomment-931230479
Thanks a ton for seeing this through in my absence @HoustonPutman . Will be
awesome to see this in 0.5.0!
--
This is an automated message from the Apache Git Service.
gerlowskija commented on pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#issuecomment-925988303
> Instead of lists for each individual repository type, we structure it more
like Volumes
Houston and I discussed this a bit offline and I'm 👍 on the alternate syn
gerlowskija commented on pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#issuecomment-920864635
Thanks Houston - I saw that 'make lint' advises using 'go fmt' to
autocorrect issues as well. Lots of options it looks like haha.
--
This is an automated message from
gerlowskija commented on pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#issuecomment-920860482
Actually - I see there are a few errors in the PR build that come out of
'make lint'. It looks like the 'lint' output proposes a fix in each line that
has bad indentati
gerlowskija commented on pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#issuecomment-920856983
Alright, quick update on my progress here. Since I last posted, I've
- addressed all of Houston's requests (except two where I asked for
clarification on what he
gerlowskija commented on pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#issuecomment-916986870
Thanks!
> Mind if I make some changes while you are working on other stuff?
Not at all, thanks for the help! My plate cleared up a bit after posting
the ot
gerlowskija commented on pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#issuecomment-915142671
Haven't touched this in a few weeks. Both because of some competing
priorities where I work, and because I've been scrambling to get things done
before I disappear for
gerlowskija commented on pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#issuecomment-904077839
Thanks for the review Houston. Just getting back from some time off now;
gonna try to address your comments in the next day or two, as well as getting
the docs and test
gerlowskija commented on pull request #302:
URL: https://github.com/apache/solr-operator/pull/302#issuecomment-898666314
I've updated this to use different CRD's (see the latest comment on the
related issue #301). This also adds support for defining multiple backup
repositories in your so