Re: [PR] [SOLR-10654] Rename instances of SolrPrometheusExporter to SolrPrometheusFormatter [solr]

2024-08-07 Thread via GitHub
dsmiley merged PR #2620: URL: https://github.com/apache/solr/pull/2620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] [SOLR-10654] Rename instances of SolrPrometheusExporter to SolrPrometheusFormatter [solr]

2024-08-07 Thread via GitHub
dsmiley commented on PR #2620: URL: https://github.com/apache/solr/pull/2620#issuecomment-2274889982 Thanks for doing this. Indeed; IntelliJ excels at refactorings. I'll merge this into 9.7 tonight. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [SOLR-10654] Rename instances of SolrPrometheusExporter to SolrPrometheusFormatter [solr]

2024-08-06 Thread via GitHub
mlbiscoc commented on PR #2620: URL: https://github.com/apache/solr/pull/2620#issuecomment-2271654565 @dsmiley Luckily Intellij makes everything relatively easy to rename. Renamed everything from `exporter` to `formatter`. I personally like `formatter` better than your recommendation of `fo

[PR] [SOLR-10654] Rename instances of SolrPrometheusExporter to SolrPrometheusFormatter [solr]

2024-08-06 Thread via GitHub
mlbiscoc opened a new pull request, #2620: URL: https://github.com/apache/solr/pull/2620 https://issues.apache.org/jira/browse/SOLR-10654 # Description Internal `SolrPrometheusExporter` names was confusing with existing `Prometheus Exporter`. # Solution