iamsanjay merged PR #2528:
URL: https://github.com/apache/solr/pull/2528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
epugh commented on PR #2528:
URL: https://github.com/apache/solr/pull/2528#issuecomment-2303641376
Tests all pass, and no issues raised, so I htink you can merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
iamsanjay commented on PR #2528:
URL: https://github.com/apache/solr/pull/2528#issuecomment-2303632234
Can we merge this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
epugh commented on PR #2528:
URL: https://github.com/apache/solr/pull/2528#issuecomment-2282121462
I will leave this open for another few days, just to see if we get any other
+1 on the code change, and then look to merge.
--
This is an automated message from the Apache Git Service.
To re
epugh commented on PR #2528:
URL: https://github.com/apache/solr/pull/2528#issuecomment-2282112021
I lean towards letting this happen in 9.8... Since what we really care is
that this gets us to Java 21 which will only be in `main`, when this code
actually goes out doesn't matter, and the 9
iamsanjay commented on PR #2528:
URL: https://github.com/apache/solr/pull/2528#issuecomment-2281743234
cherry-picked the latest fix (#2539) and moved the change description under
9.8. Should we consider including this in 9.7 if it's still possible?
--
This is an automated message from the
epugh commented on PR #2528:
URL: https://github.com/apache/solr/pull/2528#issuecomment-2210664506
> Mainly, we are looking for any special character that could fail the URI
parsing. So far there is one example from the past where passing caret(^)
symbol in the query params failed it, and n
iamsanjay commented on PR #2528:
URL: https://github.com/apache/solr/pull/2528#issuecomment-2208128385
Mainly, we are looking for any special character that could fail the URI
parsing. So far there is one example from the past where passing caret(^)
symbol in the query params failed it, and
iamsanjay commented on PR #2528:
URL: https://github.com/apache/solr/pull/2528#issuecomment-2208116261
I’d like to resolve this issue, but before that, we need to address issue
#2539. A test case failed on a Windows machine because of the backslash
character. URI is stricter compared to URL
iamsanjay opened a new pull request, #2528:
URL: https://github.com/apache/solr/pull/2528
#2501 backport blocked due to SOLR-16911. For conflicted files, I used the
older code only rather than moving bits from #1810
--
This is an automated message from the Apache Git Service.
To resp
10 matches
Mail list logo
