aparnasuresh85 commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1697348772
##
solr/core/src/test/org/apache/solr/TestTimeAllowedSearch.java:
##
@@ -0,0 +1,104 @@
+package org.apache.solr;
+
+import com.carrotsearch.randomizedtesting.genera
aparnasuresh85 commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1697395105
##
solr/core/src/test/org/apache/solr/TestTimeAllowedSearch.java:
##
@@ -0,0 +1,104 @@
+package org.apache.solr;
+
+import com.carrotsearch.randomizedtesting.genera
aparnasuresh85 commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1697348772
##
solr/core/src/test/org/apache/solr/TestTimeAllowedSearch.java:
##
@@ -0,0 +1,104 @@
+package org.apache.solr;
+
+import com.carrotsearch.randomizedtesting.genera
aparnasuresh85 commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1697023501
##
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##
@@ -211,23 +216,33 @@ public ShardResponse takeCompletedIncludingErrors() {
*/
aparnasuresh85 commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1697023501
##
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##
@@ -211,23 +216,33 @@ public ShardResponse takeCompletedIncludingErrors() {
*/
aparnasuresh85 commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1697023501
##
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##
@@ -211,23 +216,33 @@ public ShardResponse takeCompletedIncludingErrors() {
*/
aparnasuresh85 commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1697023501
##
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##
@@ -211,23 +216,33 @@ public ShardResponse takeCompletedIncludingErrors() {
*/
aparnasuresh85 commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1697023501
##
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##
@@ -211,23 +216,33 @@ public ShardResponse takeCompletedIncludingErrors() {
*/
hiteshk25 commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2218138160
Pining @gus-asf - sorry to bother you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
gus-asf commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2166986928
Am on vacation this week, will try to look Sunday after I get back.
On Tue, Jun 11, 2024 at 7:40 PM Hitesh Khamesra ***@***.***>
wrote:
> ***@***. commented on this pull r
hiteshk25 commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1635595108
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -557,7 +558,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse
dsmiley commented on code in PR #2493:
URL: https://github.com/apache/solr/pull/2493#discussion_r1629870347
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -557,7 +558,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse r
sigram commented on PR #2493:
URL: https://github.com/apache/solr/pull/2493#issuecomment-2152663345
This only checks for the timeAllowed limit but the concept of query limits
has been extended in SOLR-17138. Also, there's another Jira ticket with a
similar scope: https://issues.apache.org/j
hiteshk25 opened a new pull request, #2493:
URL: https://github.com/apache/solr/pull/2493
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
14 matches
Mail list logo