Re: [PR] Associate with each replica type a property for "numReplicas" [solr]

2023-10-24 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1369877874 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -118,9 +188,17 @@ public Replica.Type getLeaderType() { + "), there must be at leas

Re: [PR] Associate with each replica type a property for "numReplicas" [solr]

2023-10-24 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1369878681 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -18,31 +18,92 @@ import java.util.Arrays; import java.util.EnumMap; +import java.util.EnumSe

[PR] Associate with each replica type a property for "numReplicas" [solr]

2023-10-24 Thread via GitHub
pvcnt opened a new pull request, #2039: URL: https://github.com/apache/solr/pull/2039 https://issues.apache.org/jira/browse/SOLR-16995 # Description I am resuming refactoring started in #1928 and #1981 with the goal of simplifying/centralising code related to replic