Re: [PR] Correct the log.error to include the file name instead of hard-coded … [solr]

uschindler commented on PR #2186: URL: https://github.com/apache/solr/pull/2186#issuecomment-1883713569 Will cherrypick this commit on 9.x. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

uschindler commented on PR #2183: URL: https://github.com/apache/solr/pull/2183#issuecomment-1883708218 Please learn how to use git correctly next time. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

uschindler closed pull request #2183: Correct the log.error to include the file name instead of hard coded … URL: https://github.com/apache/solr/pull/2183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Correct the log.error to include the file name instead of hard-coded … [solr]

uschindler merged PR #2186: URL: https://github.com/apache/solr/pull/2186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

uschindler closed pull request #2183: Correct the log.error to include the file name instead of hard coded … URL: https://github.com/apache/solr/pull/2183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

uschindler commented on PR #2183: URL: https://github.com/apache/solr/pull/2183#issuecomment-1883700130 You could have been merged from main. 😜 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

haldmour-atypon commented on PR #2183: URL: https://github.com/apache/solr/pull/2183#issuecomment-1883653394 > Can't merge this as there's a conflict. Can you please fix the conflicts? Will merge the changes asap. https://github.com/apache/solr/pull/2186 -- This is an a

[PR] Correct the log.error to include the file name instead of hard-coded … [solr]

haldmour-atypon opened a new pull request, #2186: URL: https://github.com/apache/solr/pull/2186 …value https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request.

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

uschindler commented on PR #2183: URL: https://github.com/apache/solr/pull/2183#issuecomment-1883385837 Can't merge this as there's a conflict. Can you please fix the conflicts? Will merge the changes asap. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

uschindler commented on PR #2183: URL: https://github.com/apache/solr/pull/2183#issuecomment-1881612565 It looks like all tests pass. Would you please add an entry to the CHANGES.txt file in the 9.5 section: https://github.com/apache/solr/blob/91a19404fc90929b70c8513a058cfb1d560496da/solr/C

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

uschindler commented on code in PR #2183: URL: https://github.com/apache/solr/pull/2183#discussion_r1444777176 ## solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java: ## @@ -307,7 +307,8 @@ private static float[] getFloats(FileFloatSource ffs, IndexReader re

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

haldmour-atypon commented on code in PR #2183: URL: https://github.com/apache/solr/pull/2183#discussion_r1444760037 ## solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java: ## @@ -307,7 +307,8 @@ private static float[] getFloats(FileFloatSource ffs, IndexRead

Re: [PR] Correct the log.error to include the file name instead of hard coded … [solr]

uschindler commented on code in PR #2183: URL: https://github.com/apache/solr/pull/2183#discussion_r1444750334 ## solr/core/src/java/org/apache/solr/search/function/FileFloatSource.java: ## @@ -307,7 +307,8 @@ private static float[] getFloats(FileFloatSource ffs, IndexReader re

[PR] Correct the log.error to include the file name instead of hard coded … [solr]

haldmour-atypon opened a new pull request, #2183: URL: https://github.com/apache/solr/pull/2183 Correct the log.error to include the file name instead of the hard-coded value. `log.error("Error loading external value source + fileName + {}{}", var33, otherErrors < 10 ? "" : "\tSkippi