gus-asf commented on PR #2710:
URL: https://github.com/apache/solr/pull/2710#issuecomment-2380857581
Can we update the title of this? is it just about CLI stuff? hard to know
what this is about...
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
malliaridis commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1779652256
##
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##
@@ -122,16 +124,36 @@ public List getOptions() {
.desc(
"Skip safety checks
malliaridis commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1779655317
##
solr/packaging/test/test_create.bats:
##
@@ -34,8 +34,31 @@ teardown() {
assert_output --partial "Created new core 'COLL_NAME'"
}
+@test "create_core works" {
epugh commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1773243472
##
solr/packaging/test/test_create.bats:
##
@@ -34,8 +34,31 @@ teardown() {
assert_output --partial "Created new core 'COLL_NAME'"
}
+@test "create_core works" {
+ ru
janhoy commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1765867710
##
solr/packaging/test/test_create.bats:
##
@@ -34,8 +34,31 @@ teardown() {
assert_output --partial "Created new core 'COLL_NAME'"
}
+@test "create_core works" {
+ r
epugh commented on PR #2710:
URL: https://github.com/apache/solr/pull/2710#issuecomment-2358918287
@janhoy I've gone through and addressed (hopefully!) all your commits. Can
I get a LGTM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
epugh commented on PR #2710:
URL: https://github.com/apache/solr/pull/2710#issuecomment-2358916490
> Thanks for quick PR. Looking good, not taken it for a spin, but very nice
with the BATS tests.
>
> Will we need edit to `solr.cmd` you think?
Checked and yes, we had to fix heal
epugh commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1765362678
##
solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java:
##
@@ -170,7 +172,15 @@ protected void runCloudTool(CloudSolrClient
cloudSolrClient, CommandLine cli) th
epugh commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1765299626
##
solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java:
##
@@ -170,7 +172,15 @@ protected void runCloudTool(CloudSolrClient
cloudSolrClient, CommandLine cli) th
epugh commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1765266710
##
solr/core/src/java/org/apache/solr/cli/ToolBase.java:
##
@@ -34,18 +34,29 @@ protected ToolBase(PrintStream stdout) {
}
protected void echoIfVerbose(final String
epugh commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1765264771
##
solr/packaging/test/test_create.bats:
##
@@ -34,8 +34,31 @@ teardown() {
assert_output --partial "Created new core 'COLL_NAME'"
}
+@test "create_core works" {
+ ru
epugh commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1765232692
##
solr/packaging/test/test_healthcheck.bats:
##
@@ -29,8 +29,9 @@ teardown() {
}
@test "healthcheck on cloud solr" {
- solr start -c -e films
- run solr healthcheck -
janhoy commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1759754331
##
solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java:
##
@@ -170,7 +172,15 @@ protected void runCloudTool(CloudSolrClient
cloudSolrClient, CommandLine cli) th
epugh commented on PR #2710:
URL: https://github.com/apache/solr/pull/2710#issuecomment-2350120166
Okay, I think this is ready for review and commit. I am thinking that I
move the bats tests in another PR to `branch_9x` to see what breaks there, and
then do a PR to fix `branch_9x`. Then,
14 matches
Mail list logo
