mkhludnev commented on code in PR #2086:
URL: https://github.com/apache/solr/pull/2086#discussion_r1403754766
##
solr/core/src/test/org/apache/solr/core/BlobRepositoryMockingTest.java:
##
@@ -71,7 +71,8 @@ public void setUp() throws Exception {
super.setUp();
blobFetch
mkhludnev commented on PR #2086:
URL: https://github.com/apache/solr/pull/2086#issuecomment-1824921836
pushed fix into main and branch_9x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
madrob commented on code in PR #2086:
URL: https://github.com/apache/solr/pull/2086#discussion_r1403698891
##
solr/core/src/test/org/apache/solr/core/BlobRepositoryMockingTest.java:
##
@@ -71,7 +71,8 @@ public void setUp() throws Exception {
super.setUp();
blobFetched
mkhludnev commented on code in PR #2086:
URL: https://github.com/apache/solr/pull/2086#discussion_r1403690969
##
solr/core/src/test/org/apache/solr/core/BlobRepositoryMockingTest.java:
##
@@ -71,7 +71,8 @@ public void setUp() throws Exception {
super.setUp();
blobFetch
janhoy commented on PR #2086:
URL: https://github.com/apache/solr/pull/2086#issuecomment-1823635256
I fixed the formatting, but the test changes in this commit still fails
errorprone tests
```bash
$ gradle solr:core:check -x test -Pvalidation.errorprone=true
> Task :solr:core:co
dsmiley commented on PR #2086:
URL: https://github.com/apache/solr/pull/2086#issuecomment-1823596078
@jdyer1 I strongly recommend against pushing commits to main from your
machine. If it were up to me, it'd be made to be impossible to help avoid
mistakes. Nowadays we use GitHub which runs
janhoy commented on PR #2086:
URL: https://github.com/apache/solr/pull/2086#issuecomment-1823499479
You left main branch failing precommit
```
Execution failed for task ':solr:core:spotlessJavaCheck'.
> The following files had format violations:
src/test/org/apache/solr/core
jdyer1 commented on PR #2086:
URL: https://github.com/apache/solr/pull/2086#issuecomment-1823074811
Thank you @madrob for the review. I cleaned a few things up, then pushed
the commits via cherry-pick to "main" and "branch_9x".
--
This is an automated message from the Apache Git Service.
jdyer1 closed pull request #2086: Fix test failure on J9: do not mock jre class
URL: https://github.com/apache/solr/pull/2086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
madrob commented on code in PR #2086:
URL: https://github.com/apache/solr/pull/2086#discussion_r1401158281
##
solr/core/src/test/org/apache/solr/core/BlobRepositoryMockingTest.java:
##
@@ -151,15 +151,14 @@ public void testGetBlobIncrRefByUrl() throws Exception {
@Test
pub
jdyer1 commented on PR #2086:
URL: https://github.com/apache/solr/pull/2086#issuecomment-1821350308
It has been a _Very long time_ since I have used my commit powers here.
This J9 test failure seemed like a nice way to try and get back into it a
little. I didn't test this with J9 but conv
jdyer1 opened a new pull request, #2086:
URL: https://github.com/apache/solr/pull/2086
[No JIRA Issue]
- Fix test failure on J9: do not mock jre class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
12 matches
Mail list logo
