Re: [PR] Introduce requestAsync Method in SolrClient for API Consistency and Extensibility [solr]

2024-09-28 Thread via GitHub
iamsanjay commented on PR #2724: URL: https://github.com/apache/solr/pull/2724#issuecomment-2381044293 As you must have seen now that we are doing the migration we are facing some challenges relating to HttpSolrClient, in some cases It also exposed HttpClient -- `SolrClientCloudManager`, `H

Re: [PR] Introduce requestAsync Method in SolrClient for API Consistency and Extensibility [solr]

2024-09-28 Thread via GitHub
dsmiley commented on PR #2724: URL: https://github.com/apache/solr/pull/2724#issuecomment-2380894586 IMO it's a questionable practice to add a method that will often throw UnsupportedOperationException. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] Introduce requestAsync Method in SolrClient for API Consistency and Extensibility [solr]

2024-09-27 Thread via GitHub
dsmiley commented on code in PR #2724: URL: https://github.com/apache/solr/pull/2724#discussion_r1779101220 ## solr/solrj/src/java/org/apache/solr/client/solrj/SolrClient.java: ## @@ -1225,4 +1228,30 @@ public SolrRequest.SolrClientContext getContext() { public String getDefa

[PR] Introduce requestAsync Method in SolrClient for API Consistency and Extensibility [solr]

2024-09-27 Thread via GitHub
iamsanjay opened a new pull request, #2724: URL: https://github.com/apache/solr/pull/2724 This PR introduces an abstract requestAsync method in the SolrClient class to provide a unified and symmetrical API for asynchronous requests across different implementations of SolrClient. The method