Re: [PR] Pass exporter args as env vars where possible [solr-operator]

2023-10-04 Thread via GitHub
gerlowskija merged PR #639: URL: https://github.com/apache/solr-operator/pull/639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sol

Re: [PR] Pass exporter args as env vars where possible [solr-operator]

2023-10-02 Thread via GitHub
HoustonPutman commented on PR #639: URL: https://github.com/apache/solr-operator/pull/639#issuecomment-1743716056 > 1. How do we want to handle the potential conflict between user-specified env-vars, and values like `.Spec.NumThreads` that are converted into an env-var by the operator? Cur

Re: [PR] Pass exporter args as env vars where possible [solr-operator]

2023-10-02 Thread via GitHub
gerlowskija commented on PR #639: URL: https://github.com/apache/solr-operator/pull/639#issuecomment-1743692444 Two questions I could use a bit of clarity on before this can be merged: 1. How do we want to handle the potential conflict between user-specified env-vars, and values like

[PR] Pass exporter args as env vars where possible [solr-operator]

2023-10-02 Thread via GitHub
gerlowskija opened a new pull request, #639: URL: https://github.com/apache/solr-operator/pull/639 In recent versions of Solr (>=8.8) the prometheus exporter has an env-var equivalent for each CLI argument taken by its start script. This commit switches the operator over to providing