Re: [PR] SOLR-10654: Override PrometheusResponseWriter Content Type [solr]

2024-08-07 Thread via GitHub
dsmiley merged PR #2616: URL: https://github.com/apache/solr/pull/2616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-10654: Override PrometheusResponseWriter Content Type [solr]

2024-08-07 Thread via GitHub
dsmiley commented on code in PR #2616: URL: https://github.com/apache/solr/pull/2616#discussion_r1707038840 ## solr/core/src/java/org/apache/solr/response/PrometheusResponseWriter.java: ## @@ -49,7 +49,7 @@ */ @SuppressWarnings(value = "unchecked") public class PrometheusRes

Re: [PR] SOLR-10654: Override PrometheusResponseWriter Content Type [solr]

2024-08-06 Thread via GitHub
dsmiley commented on code in PR #2616: URL: https://github.com/apache/solr/pull/2616#discussion_r1706394845 ## solr/core/src/java/org/apache/solr/response/PrometheusResponseWriter.java: ## @@ -49,6 +49,7 @@ */ @SuppressWarnings(value = "unchecked") public class PrometheusRes

Re: [PR] SOLR-10654: Override PrometheusResponseWriter Content Type [solr]

2024-08-05 Thread via GitHub
mlbiscoc commented on PR #2616: URL: https://github.com/apache/solr/pull/2616#issuecomment-2270328349 > Did you at least test manually? (this is totally adequate) Yes, here is the before: ``` curl -I "localhost:8983/solr/admin/metrics?wt=prometheus" HTTP/1.1 200 OK Content-

Re: [PR] SOLR-10654: Override PrometheusResponseWriter Content Type [solr]

2024-08-05 Thread via GitHub
dsmiley commented on PR #2616: URL: https://github.com/apache/solr/pull/2616#issuecomment-2270323650 Did you at least test manually? (this is totally adequate) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] [SOLR-10654] Override PrometheusResponseWriter Content Type [solr]

2024-08-05 Thread via GitHub
mlbiscoc opened a new pull request, #2616: URL: https://github.com/apache/solr/pull/2616 https://issues.apache.org/jira/browse/SOLR-10654 # Description The Prometheus Response Writer response content type was JSON which is incorrect. # Solution Based o