epugh commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2321809166
I've poked around a bit and am very interested in seeing it move forward!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
malliaridis commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2321700431
I plan to prepare a presentation + meeting where I go through the code,
explain a few things and eventually do some live coding to show how to read the
code, structure things and get sta
gerlowskija commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2318288713
Curious where we stand on this POC?
If I remember right, the main question that needs answered at this point is:
"Do we think UI code in Kotlin is a better fit for our community of
janhoy commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2282256612
UI should absolutely be a standard component as always, imo not suited as a
pkg. if we decide that solr should ship without a UI then that should be a
separate decision, decoupled from this t
malliaridis commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2282037617
> How does this handle authentication/authorization. I'm hoping we have some
really nice support that can leverage what solr already has.
I am eager to imlpement it since the first
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1712645075
##
solr/compose-ui/src/commonMain/composeResources/values/strings.xml:
##
@@ -0,0 +1,46 @@
+
+
+
+
Review Comment:
Even if we would support english only, it is not
epugh commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2281249722
I got it to run! `http://localhost:8983/solr/compose`!So, it might be
a bit of bike shedding, but I wonder if it should just be called `ui`? Just
to distingush it from `admin`? Or may
epugh commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1712628817
##
solr/compose-ui/src/commonMain/composeResources/values/strings.xml:
##
@@ -0,0 +1,46 @@
+
+
+
+
Review Comment:
is this a default pattern? If we are never going to
epugh commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1712628470
##
solr/licenses/raleway-OFL.txt:
##
@@ -0,0 +1,93 @@
+Copyright 2010 The Raleway Project Authors (impall...@gmail.com), with
Reserved Font Name "Raleway".
+
+This Font Sof
epugh commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2281165657
Changing to `org.gradle.jvmargs=-Xmx2g` in `gradle.properties` allowed the
`dev` target to complete!
--
This is an automated message from the Apache Git Service.
To respond to the message, p
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1711563638
##
build.gradle:
##
@@ -195,8 +214,8 @@ apply from: file('gradle/hacks/gradle-archives.gradle')
apply from: file('gradle/hacks/wipe-temp.gradle')
apply from: file(
malliaridis commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2277941657
@gerlowskija and @epugh the build errors you have probably occur because of
the jvmargs in `gradpe.properties` that need to be updated. I added
`-Dkotlin.daemon.jvm.options\="-Xmx2048M"
epugh commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2277829774
I am getting an error when running `./gradlew dev`:
```
Execution failed for task
':solr:compose-ui:compileProductionExecutableKotlinWasmJs'.
> A failure occurred while executing
org.
epugh commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1711339498
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1709602921
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1709602921
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
fsparv commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1709553089
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
gerlowskija commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1709424728
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
gerlowskija commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1709425822
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/main/MainContent.kt:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
gerlowskija commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1709424728
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
gerlowskija commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1709410616
##
dev-docs/ui/technology-overview.adoc:
##
@@ -0,0 +1,83 @@
+= Technology Overview
Review Comment:
Yeah, it ended up not being too bad once I got into the actual
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708222059
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/utils/HttpClientUtils.kt:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
malliaridis commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2274591704
> 2. The biggest downside in the code for me is how boilerplate heavy it is.
There are Component interfaces, which have Component implementations, which
then reference Models, which com
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708121034
##
solr/server/etc/jetty.xml:
##
@@ -95,7 +95,7 @@
/solr/*
Content-Security-Policy
-default-src 'none'; base-uri 'non
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708117136
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/utils/HttpClientUtils.kt:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708109571
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/theme/Colors.kt:
##
@@ -0,0 +1,766 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708102341
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/main/MainContent.kt:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708085072
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708085072
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/icons/SolrLogo.kt:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708076547
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/environment/VersionsCard.kt:
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundat
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708073337
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/ui/environment/EnvironmentContent.kt:
##
@@ -0,0 +1,123 @@
+/*
+ * Licensed to the Apache Software F
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708066620
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/components/main/MainComponent.kt:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Founda
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708065517
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/components/environment/integration/Mappers.kt:
##
Review Comment:
I am not sure if your questio
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708063991
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/components/environment/data/JavaPropertiesResponse.kt:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the A
epugh commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708064021
##
solr/compose-ui/src/commonMain/composeResources/font/firacode-variable.ttf:
##
Review Comment:
also, I would't go through heroics to match the existing UI styles...
epugh commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708062769
##
solr/compose-ui/src/commonMain/kotlin/org/apache/solr/composeui/utils/HttpClientUtils.kt:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708060169
##
solr/compose-ui/src/commonMain/composeResources/font/firacode-variable.ttf:
##
Review Comment:
It is possible to use a dependency and load the fonts "dynamical
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708057897
##
solr/compose-ui/build.gradle.kts:
##
@@ -0,0 +1,134 @@
+/*
Review Comment:
I was considering migrating to Kotlin DSL if we start using Kotlin in
general. But i
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708055052
##
solr/api/build.gradle:
##
@@ -16,8 +18,8 @@
*/
plugins {
- id 'io.swagger.core.v3.swagger-gradle-plugin' version '2.2.2'
- id "org.openapi.generator" version
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708054252
##
gradle/libs.versions.toml:
##
@@ -0,0 +1,65 @@
+[versions]
Review Comment:
I am currently working on a migration to use version catalogs in the entire
project
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708053334
##
dev-docs/ui/technology-overview.adoc:
##
@@ -0,0 +1,83 @@
+= Technology Overview
Review Comment:
I listed all libraries here in detail, even though some of them
malliaridis commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708050511
##
build.gradle:
##
@@ -20,6 +20,10 @@ import java.time.format.DateTimeFormatter
plugins {
id 'base'
+ alias(libs.plugins.kotlinMultiplatform) apply false
Revi
epugh commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708030153
##
solr/server/etc/jetty.xml:
##
@@ -95,7 +95,7 @@
/solr/*
Content-Security-Policy
-default-src 'none'; base-uri 'none'; co
epugh commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1708029278
##
dev-docs/ui/technology-overview.adoc:
##
@@ -0,0 +1,83 @@
+= Technology Overview
Review Comment:
I think "sheer number" is okay, have you ever looked at a React app?
gerlowskija commented on PR #2605:
URL: https://github.com/apache/solr/pull/2605#issuecomment-2273958773
Also - when I check out this code locally it compiles fine in my IDE, but
I'm having trouble running the packaging tasks (e.g. `./gradlew assemble`) in
my terminal. The gradle build han
gerlowskija commented on code in PR #2605:
URL: https://github.com/apache/solr/pull/2605#discussion_r1707007092
##
dev-docs/ui/testing-and-deployment.adoc:
##
@@ -0,0 +1,19 @@
+= Testing and Deployment
+
+== Testing
+
Review Comment:
[0] Not important, just leaving this comm
46 matches
Mail list logo
