epugh merged PR #2580:
URL: https://github.com/apache/solr/pull/2580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on PR #2580:
URL: https://github.com/apache/solr/pull/2580#issuecomment-2246635757
Sure, great steps in right direction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
epugh commented on PR #2580:
URL: https://github.com/apache/solr/pull/2580#issuecomment-2246262293
@janhoy what do you think about me merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
janhoy commented on code in PR #2580:
URL: https://github.com/apache/solr/pull/2580#discussion_r1687258156
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -59,6 +60,26 @@ public String getName() {
return "auth";
}
+ @Override
+ public String getUsage()
epugh commented on code in PR #2580:
URL: https://github.com/apache/solr/pull/2580#discussion_r1686801285
##
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##
@@ -59,6 +59,16 @@ public String getName() {
return "delete";
}
+ @Override
+ public String getHead
epugh commented on code in PR #2580:
URL: https://github.com/apache/solr/pull/2580#discussion_r1686799934
##
solr/core/src/java/org/apache/solr/cli/AuthTool.java:
##
@@ -59,6 +60,26 @@ public String getName() {
return "auth";
}
+ @Override
+ public String getUsage()
epugh commented on PR #504:
URL: https://github.com/apache/solr/pull/504#issuecomment-224278
I believe I've pulled all the good stuff into the new PR. @thelabdude
would love any review ;-)!
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
epugh closed pull request #504: SOLR-15831: Refactor bin/solr and bin/solr.cmd
to delegate args parsing and usage help to SolrCLI
URL: https://github.com/apache/solr/pull/504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
epugh opened a new pull request, #2580:
URL: https://github.com/apache/solr/pull/2580
https://issues.apache.org/jira/browse/SOLR-15831
# Description
This picks up on work that was first done in #504 to migrate logic from
shell and command scripts to Java logic.
# Sol
epugh commented on PR #504:
URL: https://github.com/apache/solr/pull/504#issuecomment-2241541204
Some of the ideas in this PR ended up in #2545 as well. I am going to
look a bit more at how PackageTool does it's extended help information, and see
if we can use that approach more in other
epugh commented on PR #504:
URL: https://github.com/apache/solr/pull/504#issuecomment-1749853307
Hey @thelabdude I went through this PR, and I think at this point I've
combed out all the good stuff in this PR already and have committed them in
various PR's.Are you comfortable with me cl
epugh commented on PR #504:
URL: https://github.com/apache/solr/pull/504#issuecomment-1749683189
Boy I wish I had seen this PR a long time ago...A lot of good stuff in
here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
12 matches
Mail list logo
