epugh merged PR #2577:
URL: https://github.com/apache/solr/pull/2577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
malliaridis commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1688758777
##
solr/bin/solr.cmd:
##
@@ -292,7 +292,6 @@ IF "%FIRST_ARG%"=="-help" goto run_solrcli
IF "%FIRST_ARG%"=="-usage" goto run_solrcli
IF "%FIRST_ARG%"=="-h" goto run_s
malliaridis commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1688763185
##
solr/packaging/test/test_adminconsole_urls.bats:
##
@@ -25,7 +25,7 @@ teardown() {
# save a snapshot of SOLR_HOME for failed tests
save_home_on_failure
- s
malliaridis commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1688759945
##
solr/bin/solr.cmd:
##
@@ -1525,10 +1524,10 @@ IF "!ZK_OP!"=="" (
set CONNECTION_PARAMS=""
IF "!ZK_OP!"=="" (
- set CONNECTION_PARAMS="-solrUrl !ZK_SOLR_URL!"
+
malliaridis commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1688758777
##
solr/bin/solr.cmd:
##
@@ -292,7 +292,6 @@ IF "%FIRST_ARG%"=="-help" goto run_solrcli
IF "%FIRST_ARG%"=="-usage" goto run_solrcli
IF "%FIRST_ARG%"=="-h" goto run_s
epugh commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1686856221
##
solr/core/src/test/org/apache/solr/cli/AuthToolTest.java:
##
@@ -70,7 +70,7 @@ public void testEnableAuth() throws Exception {
dir.toAbsolutePath().toString(),
epugh commented on PR #2577:
URL: https://github.com/apache/solr/pull/2577#issuecomment-2241516075
There are updates in `main` to `test_post.bats` and `test_help.bats` that
you probably want ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
epugh commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1685667779
##
solr/bin/solr.cmd:
##
@@ -1525,10 +1524,10 @@ IF "!ZK_OP!"=="" (
set CONNECTION_PARAMS=""
IF "!ZK_OP!"=="" (
- set CONNECTION_PARAMS="-solrUrl !ZK_SOLR_URL!"
+ set
epugh commented on code in PR #2577:
URL: https://github.com/apache/solr/pull/2577#discussion_r1685676831
##
solr/core/src/test/org/apache/solr/cli/AuthToolTest.java:
##
@@ -70,7 +70,7 @@ public void testEnableAuth() throws Exception {
dir.toAbsolutePath().toString(),
epugh commented on PR #2577:
URL: https://github.com/apache/solr/pull/2577#issuecomment-2241507248
This is some great analysis...Not sure the best way to go through
this... Maybe a topic for next week community meetup? Or a working sesion?
I think I'll comment in the code, and let
malliaridis opened a new pull request, #2577:
URL: https://github.com/apache/solr/pull/2577
https://issues.apache.org/jira/browse/SOLR-16824
# Description
This PR replaces additional deprecated single-dash arguments that were
depricated in previous PRs.
# Solution
11 matches
Mail list logo
