Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1456807677 ## solr/core/src/java/org/apache/solr/cloud/api/collections/RestoreCmd.java: ## @@ -341,10 +318,8 @@ private void createCoreLessCollection( propMap.put(Overseer.QU

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1422275525 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -18,31 +18,92 @@ import java.util.Arrays; import java.util.EnumMap; +import java.util.EnumSe

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc merged PR #2039: URL: https://github.com/apache/solr/pull/2039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420516838 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420509303 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } + /**

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420479790 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } +

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420472150 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1420468337 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -18,31 +18,92 @@ import java.util.Arrays; import java.util.EnumMap; +import java.util.Enu

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

dsmiley commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r141854 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message,

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1412177582 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message, St

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1412175777 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message, St

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

dsmiley commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1412173803 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#N

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

dsmiley commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1412169466 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message,

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1411740234 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message, St

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

dsmiley commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1411096660 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message,

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1411071522 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message, St

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

dsmiley commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1411005196 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message,

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410885652 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410877477 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } + /**

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410874536 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -100,6 +166,10 @@ public int total() { return countByType.values().stream().reduce(Integer:

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410873835 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateShardCmd.java: ## @@ -35,19 +31,21 @@ import org.apache.solr.common.cloud.Replica; import org.apache.solr

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

dsmiley commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410860010 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#N

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410856493 ## solr/core/src/java/org/apache/solr/handler/admin/api/RestoreCollectionAPI.java: ## @@ -70,15 +69,17 @@ @Path("/backups/{backupName}/restore") public class RestoreCollec

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410854522 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -61,6 +152,33 @@ public boolean contains(Replica.Type type) { return countByType.containsKe

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410851764 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

dsmiley commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410728489 ## solr/core/src/java/org/apache/solr/handler/admin/api/RestoreCollectionAPI.java: ## @@ -70,15 +69,17 @@ @Path("/backups/{backupName}/restore") public class RestoreColl

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410734912 ## solr/solrj/src/java/org/apache/solr/common/params/CollectionAdminParams.java: ## @@ -49,6 +49,8 @@ public interface CollectionAdminParams { String REPLICATION_FACTOR

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410733136 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message, St

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410729890 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410512078 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateShardCmd.java: ## @@ -97,33 +101,30 @@ public void call(ClusterState clusterState, ZkNodeProps message,

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410504918 ## solr/solrj/src/java/org/apache/solr/common/params/CollectionAdminParams.java: ## @@ -49,6 +49,8 @@ public interface CollectionAdminParams { String REPLICATION_FAC

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410498382 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -100,6 +166,10 @@ public int total() { return countByType.values().stream().reduce(Integ

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410454878 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message,

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410428468 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } +

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410415720 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReindexCollectionCmd.java: ## @@ -103,17 +104,19 @@ public class ReindexCollectionCmd implements CollApiCmds.Col

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410414352 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -18,31 +18,92 @@ import java.util.Arrays; import java.util.EnumMap; +import java.util.EnumSe

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410398381 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java: ## @@ -129,17 +129,8 @@ public String getRequestType() { } private static vo

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410392506 ## solr/solrj/src/java/org/apache/solr/common/params/CollectionAdminParams.java: ## @@ -49,6 +49,8 @@ public interface CollectionAdminParams { String REPLICATION_FACTOR

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409743662 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409418225 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateShardCmd.java: ## @@ -97,33 +101,30 @@ public void call(ClusterState clusterState, ZkNodeProps message, Na

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409417510 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReindexCollectionCmd.java: ## @@ -338,14 +339,8 @@ public void call(ClusterState clusterState, ZkNodeProps messa

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409417129 ## solr/core/src/java/org/apache/solr/cloud/api/collections/RestoreCmd.java: ## @@ -341,10 +318,10 @@ private void createCoreLessCollection( propMap.put(Overseer.QUEU

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409410101 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReindexCollectionCmd.java: ## @@ -103,17 +104,19 @@ public class ReindexCollectionCmd implements CollApiCmds.Col

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409408694 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateShardCmd.java: ## @@ -97,33 +101,30 @@ public void call(ClusterState clusterState, ZkNodeProps message, Na

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409402416 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message, St

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409402045 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -590,12 +589,22 @@ public static List populateShardNames(ZkNodeProps message, St

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409371156 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } + /**

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409398398 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -61,6 +122,11 @@ public boolean contains(Replica.Type type) { return countByType.containsKe

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409396424 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -100,6 +166,10 @@ public int total() { return countByType.values().stream().reduce(Integer:

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409392996 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409390333 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -262,12 +258,17 @@ public static Object verifyProp(Map props, String propName) { public s

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409387774 ## solr/core/src/java/org/apache/solr/handler/admin/api/RestoreCollectionAPI.java: ## @@ -70,15 +69,17 @@ @Path("/backups/{backupName}/restore") public class RestoreCollec

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409385922 ## solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementRequestImpl.java: ## @@ -33,21 +33,6 @@ public class PlacementRequestImpl implements PlacementRequest

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409383558 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateShardCmd.java: ## @@ -97,33 +101,30 @@ public void call(ClusterState clusterState, ZkNodeProps message, Na

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409373603 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409372699 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -97,9 +94,12 @@ public class CreateCollectionCmd implements CollApiCmds.Collecti

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409372280 ## solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java: ## @@ -103,31 +104,41 @@ public enum Type { * support NRT (soft commits) and RTG. Any {@link Type#NRT

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1409371156 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } + /**

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1408434915 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java: ## @@ -97,9 +94,12 @@ public class CreateCollectionCmd implements CollApiCmds.Colle