epugh commented on PR #2602:
URL: https://github.com/apache/solr/pull/2602#issuecomment-2258531459
Okay, manually ran the BATS test after your changes and it passed. I
tweaked the github configuration to also run the bats tests when ANY of the
exporter code changes. Maybe that is too
malliaridis commented on PR #2602:
URL: https://github.com/apache/solr/pull/2602#issuecomment-2257981877
> Lgtm... so.. swapping parsers was possible without forcing any changes to
the params? It appears this would be totally back wards compatible?!!
Yes, both libraries do almost the
epugh commented on PR #2602:
URL: https://github.com/apache/solr/pull/2602#issuecomment-2256619951
I manually ran the bats test: `./gradlew integrationTests --tests
test_prometheus.bats` and am seeing:
```
> Task :solr:packaging:integrationTests
Running BATS tests with Solr bas
epugh commented on PR #2602:
URL: https://github.com/apache/solr/pull/2602#issuecomment-2256204733
Have you run the Prometheus export bats test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
malliaridis opened a new pull request, #2602:
URL: https://github.com/apache/solr/pull/2602
https://issues.apache.org/jira/browse/SOLR-16996
# Description
This PR replaces the usage of `argparse4j` with `commons-cli` in
`SolrExporter.java` of the `prometheus-exporter` module.
