bruno-roustant merged PR #2021:
URL: https://github.com/apache/solr/pull/2021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
bruno-roustant commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1408997849
##
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java:
##
@@ -507,29 +504,19 @@ private boolean doVersionAdd(
bruno-roustant commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1408995357
##
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java:
##
@@ -507,29 +504,19 @@ private boolean doVersionAdd(
bruno-roustant commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1408995357
##
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java:
##
@@ -507,29 +504,19 @@ private boolean doVersionAdd(
dsmiley commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1408490861
##
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java:
##
@@ -507,29 +504,19 @@ private boolean doVersionAdd(
lastVer
bruno-roustant commented on PR #2021:
URL: https://github.com/apache/solr/pull/2021#issuecomment-1829889063
I'm going to merge this in 2 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dsmiley commented on PR #2021:
URL: https://github.com/apache/solr/pull/2021#issuecomment-1774196842
Hey way to go Bruno! Thus essentially all we need is a lock per ID (not
even necessarily "bucket"-ed); the version was an optimization and doesn't seem
to be worth its complexity? @markrmil
dsmiley commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1366914071
##
solr/core/src/java/org/apache/solr/update/VersionBucket.java:
##
@@ -31,14 +31,41 @@
* ignores the lockTimeoutMs.
*/
public class VersionBucket {
- public long hi
dsmiley commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1366911829
##
solr/core/src/java/org/apache/solr/update/VersionInfo.java:
##
@@ -284,11 +297,20 @@ public Long getMaxVersionFromIndex(IndexSearcher
searcher) throws IOException {
bruno-roustant commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1366628537
##
solr/core/src/java/org/apache/solr/update/VersionBucket.java:
##
@@ -31,14 +31,41 @@
* ignores the lockTimeoutMs.
*/
public class VersionBucket {
- public
bruno-roustant commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1366612855
##
solr/core/src/java/org/apache/solr/update/VersionInfo.java:
##
@@ -284,11 +297,20 @@ public Long getMaxVersionFromIndex(IndexSearcher
searcher) throws IOExcepti
dsmiley commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1365561237
##
solr/core/src/java/org/apache/solr/update/VersionInfo.java:
##
@@ -284,11 +297,20 @@ public Long getMaxVersionFromIndex(IndexSearcher
searcher) throws IOException {
bruno-roustant commented on PR #2021:
URL: https://github.com/apache/solr/pull/2021#issuecomment-1770534588
I removed the Map transition from this PR. The VersionBucket array is
created lazily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
bruno-roustant commented on PR #2021:
URL: https://github.com/apache/solr/pull/2021#issuecomment-1770500635
I read the code more. The VersionBucket is also used by non-leaders to wait
for dependent updates in the case of in-place update. So it's not only a lock
for atomic access.
--
This
dsmiley commented on PR #2021:
URL: https://github.com/apache/solr/pull/2021#issuecomment-1769085627
My feedback to Bruno today was overall the this Map upgrade to array (the
array we have today) seems kind of pointless; sort of inevitable (assuming
there is indexing) so why have this earli
bruno-roustant commented on PR #2021:
URL: https://github.com/apache/solr/pull/2021#issuecomment-1769002074
Actually, based on an a separate discussion with David, I'll also propose a
second PR simplified with the lazy creation of the bucket array, without the
map transition.
--
This is
bruno-roustant commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1364255196
##
solr/core/src/java/org/apache/solr/update/VersionInfo.java:
##
@@ -284,12 +344,28 @@ public Long getMaxVersionFromIndex(IndexSearcher
searcher) throws IOExcepti
bruno-roustant commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1364249747
##
solr/core/src/java/org/apache/solr/update/VersionInfo.java:
##
@@ -205,9 +215,59 @@ public VersionBucket bucket(int hash) {
// Make sure high bits are moved
stillalex commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1364231225
##
solr/core/src/java/org/apache/solr/update/VersionInfo.java:
##
@@ -284,12 +344,28 @@ public Long getMaxVersionFromIndex(IndexSearcher
searcher) throws IOException {
stillalex commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1364221046
##
solr/core/src/java/org/apache/solr/update/VersionInfo.java:
##
@@ -205,9 +215,59 @@ public VersionBucket bucket(int hash) {
// Make sure high bits are moved down
stillalex commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1364202872
##
solr/core/src/java/org/apache/solr/update/VersionBucket.java:
##
@@ -31,14 +31,41 @@
* ignores the lockTimeoutMs.
*/
public class VersionBucket {
- public long
stillalex commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1364202872
##
solr/core/src/java/org/apache/solr/update/VersionBucket.java:
##
@@ -31,14 +31,41 @@
* ignores the lockTimeoutMs.
*/
public class VersionBucket {
- public long
bruno-roustant commented on PR #2021:
URL: https://github.com/apache/solr/pull/2021#issuecomment-1768027856
Here is my understanding.
VersionBucket
It serves 2 purposes.
First, it is a lock object to lock atomic operations on a doc ID. It is a
bucket because it is used to lock o
dsmiley commented on code in PR #2021:
URL: https://github.com/apache/solr/pull/2021#discussion_r1363159588
##
solr/core/src/java/org/apache/solr/update/VersionInfo.java:
##
@@ -103,14 +113,14 @@ public VersionInfo(UpdateLog ulog, int nBuckets) {
.get("versionBucket
24 matches
Mail list logo
